Re: [RFC PATCH] selinux: increase the deprecation sleep for checkreqprot and runtime disable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/22/2022 6:50 PM, Paul Moore wrote:
> Further the checkreqprot and runtime disable deprecation efforts by
> increasing the sleep time from 5 to 15 seconds to help make this more
> noticeable for any users who are still using these knobs.
>
> Signed-off-by: Paul Moore <paul@xxxxxxxxxxxxxx>

To the extent it matters,

Acked-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>

> ---
>  security/selinux/selinuxfs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index a00d191394365..0a6894cdc54d9 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -294,7 +294,7 @@ static ssize_t sel_write_disable(struct file *file, const char __user *buf,
>  	 */
>  	pr_err("SELinux:  Runtime disable is deprecated, use selinux=0 on the kernel cmdline.\n");
>  	pr_err("SELinux:  https://github.com/SELinuxProject/selinux-kernel/wiki/DEPRECATE-runtime-disable\n";);
> -	ssleep(5);
> +	ssleep(15);
>  
>  	if (count >= PAGE_SIZE)
>  		return -ENOMEM;
> @@ -763,7 +763,7 @@ static ssize_t sel_write_checkreqprot(struct file *file, const char __user *buf,
>  
>  	checkreqprot_set(fsi->state, (new_value ? 1 : 0));
>  	if (new_value)
> -		ssleep(5);
> +		ssleep(15);
>  	length = count;
>  
>  	selinux_ima_measure_state(fsi->state);
>



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux