On Tue, Aug 16, 2022 at 8:50 AM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > Failed or incomplete test runs can leave temporary test files in > the binder test directory, remove them with 'make clean'. > > mkfifo: cannot create fifo \ > 'binder/manager_flag': File exists > mkfifo: cannot create fifo \ > 'binder/service_provider_flag': File exists > > Signed-off-by: Paul Moore <paul@xxxxxxxxxxxxxx> > --- > tests/binder/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/binder/Makefile b/tests/binder/Makefile > index e78ad16..b89d4db 100644 > --- a/tests/binder/Makefile > +++ b/tests/binder/Makefile > @@ -18,6 +18,6 @@ endif > all: $(TARGETS) > > clean: > - rm -f $(TARGETS) > + rm -f $(TARGETS) manager_flag service_provider_flag > > $(TARGETS): $(DEPS) Thanks, though it would be good to do the same cleanup also in other tests. I extended your patch to almost all other dirs in [1] - is it OK if I apply that version? Note that I didn't bother with the cleanup in filesystem/fs_filesystem tests, since the tmp dir(s) there may have mounts on them and that's harder to clean up reliably. [1] https://github.com/WOnder93/selinux-testsuite/commit/0d5c0af63544a606d42bf9bcb905fc7753994c6d -- Ondrej Mosnacek Senior Software Engineer, Linux Security - SELinux kernel Red Hat, Inc.
