Re: [PATCH 1/2] checkpolicy: use strict function prototype for definitions

[Daniel Burgener <dburgener@xxxxxxxxxxxxxxxxxxx>]

On 8/8/2022 1:36 PM, Christian Göttsche wrote:
> Clang 15 starts to complain about non strict function definitions:
>
>      policy_define.c:4907:30: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      int define_devicetree_context()
>                                   ^
>                                    void
>      policy_define.c:5298:29: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      int define_ipv4_node_context()
>                                  ^
>                                   void
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> ---
>   checkpolicy/policy_define.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/checkpolicy/policy_define.c b/checkpolicy/policy_define.c
> index 8bf36859..f3b48870 100644
> --- a/checkpolicy/policy_define.c
> +++ b/checkpolicy/policy_define.c
> @@ -4904,7 +4904,7 @@ bad:
>   	return -1;
>   }
>   
> -int define_devicetree_context()
> +int define_devicetree_context(void)
>   {
>   	ocontext_t *newc, *c, *l, *head;
>   
> @@ -5295,7 +5295,7 @@ int define_netif_context(void)
>   	return 0;
>   }
>   
> -int define_ipv4_node_context()
> +int define_ipv4_node_context(void)
>   {	
>   	char *id;
>   	int rc = 0;

Reviewed-by: Daniel Burgener <dburgener@xxxxxxxxxxxxxxxxxxx>