On Tue, Jul 19, 2022 at 12:31 AM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > Rework the SCTP tests slightly to remove two assumptions which are > not always guaranteed to be true (below). This should have not any > affect on the current test suite or released kernels, but it will > help ensure that the test suite continues to work with upcoming > kernel releases. > > * Do not rely on IP options attached to a socket. Depending on the > kernel configuration, the on-the-wire packet labels may be > generated on a per-packet basis as opposed to a per-socket basis. Could you expand a bit on why this would be a problem? It's not clear to me how switching to per-packet would break the tests. (Maybe I'm just not thinking about it hard enough, but ideally the commit message would explain the problem to me so I don't have to :) > > * Ensure the kernel's SCTP association state is properly reset by > restarting the SCTP test server between tests which require it. > > Signed-off-by: Paul Moore <paul@xxxxxxxxxxxxxx> > --- > tests/sctp/sctp_client.c | 22 +- > tests/sctp/sctp_common.c | 42 +++++ > tests/sctp/sctp_common.h | 2 > tests/sctp/sctp_peeloff_client.c | 21 +- > tests/sctp/sctp_peeloff_server.c | 20 +- > tests/sctp/sctp_server.c | 28 +-- > tests/sctp/test | 352 ++++++++++++++++++++++++++++---------- > 7 files changed, 332 insertions(+), 155 deletions(-) [...] -- Ondrej Mosnacek Senior Software Engineer, Linux Security - SELinux kernel Red Hat, Inc.
