On Wed, Jun 29, 2022 at 4:06 PM James Carter <jwcart2@xxxxxxxxx> wrote:
>
> On Wed, Jun 29, 2022 at 3:37 AM Nicolas Iooss <nicolas.iooss@xxxxxxx> wrote:
> >
> > clang's static analyzer reports that s[0] can be uninitialized when used
> > in:
> >
> > sprintf(tmp_buf, "%s %s\n",
> > xcontext ? "Validatetrans" : "Constraint",
> > s[0] ? "GRANTED" : "DENIED");
> >
> > Silence this false-positive issue by making s always initialized.
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx>
>
> Acked-by: James Carter <jwcart2@xxxxxxxxx>
>
Merged.
Thanks,
Jim
> > ---
> > libsepol/src/services.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libsepol/src/services.c b/libsepol/src/services.c
> > index d7510e9dae51..db769cdcfaf9 100644
> > --- a/libsepol/src/services.c
> > +++ b/libsepol/src/services.c
> > @@ -394,7 +394,7 @@ static int constraint_expr_eval_reason(context_struct_t *scontext,
> > role_datum_t *r1, *r2;
> > mls_level_t *l1, *l2;
> > constraint_expr_t *e;
> > - int s[CEXPR_MAXDEPTH];
> > + int s[CEXPR_MAXDEPTH] = {};
> > int sp = -1;
> > char tmp_buf[128];
> >
> > --
> > 2.36.1
> >
