On Fri, May 13, 2022 at 1:16 PM Christian Göttsche <cgzones@xxxxxxxxxxxxxx> wrote: > On Tue, 3 May 2022 at 22:02, Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > On Mon, May 2, 2022 at 9:38 AM Christian Göttsche > > <cgzones@xxxxxxxxxxxxxx> wrote: > > > On Thu, 17 Feb 2022 at 23:50, Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > > > > On 2/17/2022 6:18 AM, Christian Göttsche wrote: > > > > > The struct security_hook_list member lsm is assigned in > > > > > security_add_hooks() with string literals passed from the individual > > > > > security modules. Declare the function parameter and the struct member > > > > > const to signal their immutability. > > > > > > > > > > Reported by Clang [-Wwrite-strings]: > > > > > > > > > > security/selinux/hooks.c:7388:63: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > > > > > security_add_hooks(selinux_hooks, ARRAY_SIZE(selinux_hooks), selinux); > > > > > ^~~~~~~~~ > > > > > ./include/linux/lsm_hooks.h:1629:11: note: passing argument to parameter 'lsm' here > > > > > char *lsm); > > > > > ^ > > > > > > > > > > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx> > > > > > > > > Reviewed-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx> > > > > > > > > > > Kindly ping; > > > any progress on this one? > > > > I've already added my Reviewed-by tag, as has Casey, so I think it's > > pretty "safe" at this point. The next step is for James to pull this > > into the LSM tree. If it is still collecting dust at the end of this > > week, ping us again and I can just go ahead and pull it into the > > SELinux tree, it's small enough that it shouldn't cause any problems. > > end-of-the-week-ping Thanks for the reminder. I haven't seen any other action on this so I've gone ahead and merged this into selinux/next; thanks for your patience and persistence on this Christian! -- paul-moore.com
