A couple of comments: I'm not clear from the patch series what the difference is between an error which ignored (and counted) and an error that would actually stop setfiles immediately. With setfiles -C, will all errors now be counted and cause setfiles to exit with 1, or will some errors still be fatal (exit with 255)? Why on earth is setfiles originally calling exit(-1) at all?! I didn't even know that was allowed. I wrote a test program and this does indeed cause the exit status to be 255 (because the status is &-ed with 0xff). Never seen a program before calling exit(-1). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit
