On Fri, Apr 8, 2022 at 9:37 AM Christian Göttsche <cgzones@xxxxxxxxxxxxxx> wrote: > > ../cil/src/cil_log.c:45:8: warning: no previous extern declaration for non-static variable 'cil_log_handler' [-Wmissing-variable-declarations] > void (*cil_log_handler)(int lvl, const char *msg) = &cil_default_log_handler; > ^ > > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx> For these 5 patches: Acked-by: James Carter <jwcart2@xxxxxxxxx> > --- > libsepol/cil/src/cil_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libsepol/cil/src/cil_log.c b/libsepol/cil/src/cil_log.c > index e45c58fc..f4c6e415 100644 > --- a/libsepol/cil/src/cil_log.c > +++ b/libsepol/cil/src/cil_log.c > @@ -42,7 +42,7 @@ static void cil_default_log_handler(__attribute__((unused)) int lvl, const char > fprintf(stderr, "%s", msg); > } > > -void (*cil_log_handler)(int lvl, const char *msg) = &cil_default_log_handler; > +static void (*cil_log_handler)(int lvl, const char *msg) = &cil_default_log_handler; > > void cil_set_log_handler(void (*handler)(int lvl, const char *msg)) > { > -- > 2.35.1 >