Re: [RFC PATCH 4/4] Enable missing prototypes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 31, 2022 at 2:36 PM Christian Göttsche
<cgzones@xxxxxxxxxxxxxx> wrote:
>
> Check for missing prototypes like file local functions not declared
> static or external functions not being declared to avoid declaration/
> definition desynchronizations.
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>

We're not ready for this one yet.

    ../cil/src/cil_verify.c:973:5: warning: no previous prototype for
‘__cil_verify_rule’ [-Wmissing-prototypes]

This one is easy to handle. The function is not used, or, rather, not
fully implemented and not used. So it can be removed.

    semanageswig_wrap.c:2759:24: warning: no previous prototype for
‘PyInit__semanage’ [-Wmissing-prototypes]

This one I am not sure about.

Jim


> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 215e313e..2ffba8e9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,6 +14,7 @@ else
>                 -Winit-self \
>                 -Wmissing-format-attribute \
>                 -Wmissing-noreturn \
> +               -Wmissing-prototypes \
>                 -Wnull-dereference \
>                 -Wpointer-arith \
>                 -Wshadow \
> --
> 2.35.1
>




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux