On Thu, Feb 17, 2022 at 9:19 AM Christian Göttsche <cgzones@xxxxxxxxxxxxxx> wrote: > > The struct security_hook_list member lsm is assigned in > security_add_hooks() with string literals passed from the individual > security modules. Declare the function parameter and the struct member > const to signal their immutability. > > Reported by Clang [-Wwrite-strings]: > > security/selinux/hooks.c:7388:63: error: passing 'const char [8]' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > security_add_hooks(selinux_hooks, ARRAY_SIZE(selinux_hooks), selinux); > ^~~~~~~~~ > ./include/linux/lsm_hooks.h:1629:11: note: passing argument to parameter 'lsm' here > char *lsm); > ^ > > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx> > --- > include/linux/lsm_hooks.h | 4 ++-- > security/security.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Thanks Christian. Reviewed-by: Paul Moore <paul@xxxxxxxxxxxxxx> -- paul-moore.com
