Re: [PATCH] selinux: fix a sock regression in selinux_ip_postroute_compat()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 19, 2021 at 4:51 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
>
> On Tue, Oct 19, 2021 at 8:16 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> > Unfortunately we can't rely on nf_hook_state->sk being the proper
> > originating socket so revert to using skb_to_full_sk(skb).
> >
> > Fixes: 1d1e1ded1356 ("1d1e1ded13568be81a0e19d228e310a48997bec8")
>
> This doesn't seem right :)

It does seem a little off, doesn't it?  Thanks for catching this, I
fixed it up in my local tree.

In case anyone is interested in my long winded excuse ... I replaced
my old trusty mouse this morning (one of the buttons was starting to
become decidedly un-trusty) and while switching between my Linux
system and my Windows system (employer VPN box) I learned that my new
mouse actually gets reprogrammed on-the-fly by the Windows
driver/config-software such that my middle mouse button was
non-functional when returning the Linux and hence my usual workflow of
"highlight and middle-click" was temporarily replaced with ctrl-c and
crtl-v which was awkward and resulted in some copy-n-paste snafus.  I
wanted to get the patch posted to the list so I did that before
finding a solution to my mouse problems, perhaps that wasn't the best
order :)

-- 
paul moore
www.paul-moore.com



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux