Re: [PATCH] libselinux/semodule: Improve extracting message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 4, 2021 at 8:59 AM Petr Lautrbach <plautrba@xxxxxxxxxx> wrote:
>
> The code doesn't check the default priority, it just looks for the
> highest.
>
> Fixes:
>
>     # semodule -E testmodule
>     Module 'testmodule' does not exist at the default priority '400'. Extracting at highest existing priority '400'.
>
> Signed-off-by: Petr Lautrbach <plautrba@xxxxxxxxxx>

Acked-by: James Carter <jwcart2@xxxxxxxxx>

> ---
>  policycoreutils/semodule/semodule.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/policycoreutils/semodule/semodule.c b/policycoreutils/semodule/semodule.c
> index bf9eec02a050..66ea06624eda 100644
> --- a/policycoreutils/semodule/semodule.c
> +++ b/policycoreutils/semodule/semodule.c
> @@ -672,8 +672,7 @@ int main(int argc, char *argv[])
>                                         }
>
>                                         semanage_module_info_get_priority(sh, extract_info, &curr_priority);
> -                                       printf("Module '%s' does not exist at the default priority '%d'. "
> -                                                       "Extracting at highest existing priority '%d'.\n", mode_arg, priority, curr_priority);
> +                                       printf("Extracting at highest existing priority '%d'.\n", curr_priority);
>                                         priority = curr_priority;
>                                 }
>
> --
> 2.32.0
>



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux