On Fri, Jul 09, 2021 at 04:36:33PM -0400, Theodore Ts'o wrote: > On Fri, Jul 09, 2021 at 08:34:41AM -0700, Casey Schaufler wrote: > > >> One question, do all filesystem supporting xattrs deal with setting them > > >> on symlinks/device files correctly? > > > Wrote a simple bash script to do setfattr/getfattr user.foo xattr on > > > symlink and device node on ext4, xfs and btrfs and it works fine. > > > > How about nfs, tmpfs, overlayfs and/or some of the other less conventional > > filesystems? > > As a suggestion, perhaps you could take your bash script and turn it > into an xfstests test so we can more easily test various file systems, > both now and once the commit is accepted, to look for regressions? Sounds good. I see there is already an xattr test (generic/062) which is broken after my patch. Current test expects that user.* xattrs will fail on symlink/special device. I will probably have to query kernel version and modify test so that expect failure before a certain version and success otherwise. Thanks Vivek
