Re: [PATCH] libselinux/utils/getseuser.c: fix build with gcc 4.8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 2, 2021 at 10:18 AM Nicolas Iooss <nicolas.iooss@xxxxxxx> wrote:
>
> On Thu, Jul 1, 2021 at 7:06 PM Fabrice Fontaine
> <fontaine.fabrice@xxxxxxxxx> wrote:
> >
> > Fix the following build failure with gcc 4.8 which is raised since
> > version 3.2 and
> > https://github.com/SELinuxProject/selinux/commit/156dd0de5cad31e7d437c64e11a8aef027f0a691
> >
> > getseuser.c:53:2: error: 'for' loop initial declarations are only allowed in C99 mode
> >   for (int i = 0; i < n; i++)
> >   ^
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/37eb0952a763256fbf6ef3c668f6c95fbdf2dd35
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
>
> Acked-by: Nicolas Iooss <nicolas.iooss@xxxxxxx>
>
> If nobody else has comments, I will apply this patch tomorrow.
> Thanks!
> Nicolas

Applied.
Thanks,
Nicolas

> > ---
> >  libselinux/utils/getseuser.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libselinux/utils/getseuser.c b/libselinux/utils/getseuser.c
> > index ce1b7b27..34f2e887 100644
> > --- a/libselinux/utils/getseuser.c
> > +++ b/libselinux/utils/getseuser.c
> > @@ -9,7 +9,7 @@ int main(int argc, char **argv)
> >  {
> >         char *seuser = NULL, *level = NULL;
> >         char **contextlist;
> > -       int rc, n;
> > +       int rc, n, i;
> >
> >         if (argc != 3) {
> >                 fprintf(stderr, "usage:  %s linuxuser fromcon\n", argv[0]);
> > @@ -50,7 +50,7 @@ int main(int argc, char **argv)
> >         if (n == 0)
> >                 printf("no valid context found\n");
> >
> > -       for (int i = 0; i < n; i++)
> > +       for (i = 0; i < n; i++)
> >                 printf("Context %d\t%s\n", i, contextlist[i]);
> >
> >         freeconary(contextlist);
> > --
> > 2.30.2
> >




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux