On Tue, Jun 8, 2021 at 12:00 PM Christian Göttsche <cgzones@xxxxxxxxxxxxxx> wrote: > > Clean up several code smells, compiler warnings, static analyzer issues > and UBSAN findings in libsepol. > > Also declare local functions and variables static and some interface > parameters const to improve maintainability. > > Christian Göttsche (23): > libsepol: fix typos > libsepol: resolve missing prototypes > libsepol: remove unused functions > libsepol: ignore UBSAN false-positives > libsepol: avoid implicit conversions > libsepol: avoid unsigned integer overflow > libsepol: follow declaration-after-statement > libsepol/cil: follow declaration-after-statement > libsepol: remove dead stores > libsepol: mark read-only parameters of ebitmap interfaces const > libsepol: mark read-only parameters of type_set_ interfaces const > libsepol: do not allocate memory of size 0 > libsepol: assure string NUL-termination > libsepol: remove dead stores > libsepol/cil: silence cast warning > libsepol/cil: drop extra semicolon > libsepol/cil: drop dead store > libsepol/cil: drop unnecessary casts > libsepol/cil: avoid using maybe uninitialized variables > libsepol: drop repeated semicolons > libsepol: drop unnecessary casts > libsepol: declare file local variable static > libsepol: declare read-only arrays const > > libsepol/cil/src/cil_binary.c | 19 +-- > libsepol/cil/src/cil_build_ast.c | 9 +- > libsepol/cil/src/cil_fqn.c | 3 +- > libsepol/cil/src/cil_list.c | 7 +- > libsepol/cil/src/cil_post.c | 2 +- > libsepol/cil/src/cil_resolve_ast.c | 8 +- > libsepol/cil/src/cil_strpool.c | 16 +-- > libsepol/cil/src/cil_write_ast.c | 4 +- > libsepol/include/sepol/policydb/conditional.h | 2 +- > libsepol/include/sepol/policydb/ebitmap.h | 16 +-- > libsepol/include/sepol/policydb/policydb.h | 6 +- > libsepol/src/assertion.c | 2 +- > libsepol/src/avrule_block.c | 2 +- > libsepol/src/avtab.c | 8 +- > libsepol/src/booleans.c | 6 +- > libsepol/src/conditional.c | 3 - > libsepol/src/context_internal.h | 1 + > libsepol/src/debug.c | 2 +- > libsepol/src/ebitmap.c | 29 +++-- > libsepol/src/expand.c | 8 +- > libsepol/src/ibendport_record.c | 4 +- > libsepol/src/kernel_to_cil.c | 7 +- > libsepol/src/kernel_to_conf.c | 5 +- > libsepol/src/link.c | 2 +- > libsepol/src/module.c | 2 +- > libsepol/src/module_to_cil.c | 14 +- > libsepol/src/nodes.c | 6 +- > libsepol/src/polcaps.c | 2 +- > libsepol/src/policydb.c | 70 +++++----- > libsepol/src/policydb_internal.h | 2 +- > libsepol/src/policydb_validate.c | 2 +- > libsepol/src/private.h | 6 +- > libsepol/src/services.c | 120 ++++++------------ > libsepol/src/sidtab.c | 31 ----- > libsepol/src/symtab.c | 6 + > libsepol/src/util.c | 2 +- > libsepol/src/write.c | 8 +- > 37 files changed, 187 insertions(+), 255 deletions(-) > > -- > 2.32.0 > Merged all the patches except for 0004, 0005, and 0013 which still have outstanding comments. Thanks, Jim
