Re: [PATCH] libsemanage: fix use-after-free in parse_module_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



EJames Carter <jwcart2@xxxxxxxxx> writes:

> On Mon, Jun 14, 2021 at 12:52 AM HuaxinLu <luhuaxin1@xxxxxxxxxxx> wrote:
>>
>> The passing parameter "arg" of parse_module_store will be freed after
>> calling. A copy of parameter should be used instead of itself.
>>
>> Signed-off-by: HuaxinLu <luhuaxin1@xxxxxxxxxxx>
>
> Acked-by: James Carter <jwcart2@xxxxxxxxx>

Merged, thanks!


>> ---
>>  libsemanage/src/conf-parse.y | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libsemanage/src/conf-parse.y b/libsemanage/src/conf-parse.y
>> index 9bf9364a..eac91344 100644
>> --- a/libsemanage/src/conf-parse.y
>> +++ b/libsemanage/src/conf-parse.y
>> @@ -516,12 +516,12 @@ static int parse_module_store(char *arg)
>>                 char *s;
>>                 current_conf->store_type = SEMANAGE_CON_POLSERV_REMOTE;
>>                 if ((s = strchr(arg, ':')) == NULL) {
>> -                       current_conf->store_path = arg;
>> +                       current_conf->store_path = strdup(arg);
>>                         current_conf->server_port = 4242;
>>                 } else {
>>                         char *endptr;
>>                         *s = '\0';
>> -                       current_conf->store_path = arg;
>> +                       current_conf->store_path = strdup(arg);
>>                         current_conf->server_port = strtol(s + 1, &endptr, 10);
>>                         if (*(s + 1) == '\0' || *endptr != '\0') {
>>                                 return -2;
>> --
>> 2.26.0
>>




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux