On Thu, Jun 10, 2021 at 9:45 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Jun 10, 2021 at 07:12:15PM -0400, Paul Moore wrote: > > On Thu, Jun 10, 2021 at 11:51 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > [followup to dump_common_audit_data() changes from this winter; in vfs.git#work.audit] > > > Does anybody have objections to the below? > > > > > > From 663a40ab49308b5acaba8a335190fce66e17d969 Mon Sep 17 00:00:00 2001 > > > From: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > Date: Sat, 16 Jan 2021 15:40:54 -0500 > > > Subject: [PATCH 1/2] selinux: slow_avc_audit has become non-blocking > > > > > > dump_common_audit_data() is safe to use under rcu_read_lock() now; > > > no need for AVC_NONBLOCKING and games around it > > > > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > --- > > > security/selinux/avc.c | 28 ++++++++-------------------- > > > security/selinux/hooks.c | 13 ++----------- > > > security/selinux/include/avc.h | 4 ---- > > > 3 files changed, 10 insertions(+), 35 deletions(-) > > > > This looks okay to me, thanks Al. If you want to fix patch 2/2 I can > > pull both into selinux/next. > > Done and force-pushed into the same branch... Do you want a formal pull request? Thanks for the offer, but I can just pull those top two patches from work.audit. However, this mail came in just as I was shutting down for the evening so I'll take care of it tomorrow. -- paul moore www.paul-moore.com
