On Thu, Jun 10, 2021 at 11:52 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > From 565799de3ee0a295842a07a5f9a459db5e793beb Mon Sep 17 00:00:00 2001 > From: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Date: Sat, 16 Jan 2021 15:57:49 -0500 > Subject: [PATCH 2/2] kill unused 'flags' argument in avc_has_perm_flags() and > avc_audit() > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > --- > security/selinux/avc.c | 7 +++---- > security/selinux/hooks.c | 5 ++--- > security/selinux/include/avc.h | 7 ++----- > 3 files changed, 7 insertions(+), 12 deletions(-) I'm looking at patch 1/2 now, but if we can safely get rid of the flags arg then we might as well do away with avc_has_perm_flags() altogether and just convert the callers to avc_has_perm(). > diff --git a/security/selinux/include/avc.h b/security/selinux/include/avc.h > index c3bbfc8e8b46..098f31c415e2 100644 > --- a/security/selinux/include/avc.h > +++ b/security/selinux/include/avc.h > @@ -154,8 +152,7 @@ int avc_has_perm(struct selinux_state *state, > int avc_has_perm_flags(struct selinux_state *state, > u32 ssid, u32 tsid, > u16 tclass, u32 requested, > - struct common_audit_data *auditdata, > - int flags); > + struct common_audit_data *auditdata); > > int avc_has_extended_perms(struct selinux_state *state, > u32 ssid, u32 tsid, u16 tclass, u32 requested, > -- > 2.11.0 -- paul moore www.paul-moore.com
