The 'isec->initialized == LABEL_INITIALIZED' is checked twice in a row, since selinux was mainlined from Linux-2.6.12-rc2. Since 'isec->initialized' is protected using spin_lock(&isec->lock) within various APIs, it had better remove first exceptional routine. With this commit, the code look simpler, easier to read and maintain. Signed-off-by: Austin Kim <austindh.kim@xxxxxxxxx> --- security/selinux/hooks.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index fc6a3ab7e179..a236b0a33665 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -1448,9 +1448,6 @@ static int inode_doinit_with_dentry(struct inode *inode, struct dentry *opt_dent struct dentry *dentry; int rc = 0; - if (isec->initialized == LABEL_INITIALIZED) - return 0; - spin_lock(&isec->lock); if (isec->initialized == LABEL_INITIALIZED) goto out_unlock; -- 2.20.1
