On Thu, May 27, 2021 at 1:05 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > > On 5/27/2021 8:29 AM, Paul Moore wrote: > > On Wed, May 26, 2021 at 9:51 PM kernel test robot <lkp@xxxxxxxxx> wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git working-io_uring > >> head: 1f25193a3f5495eefbc9826b1de1a008a2439351 > >> commit: 1f25193a3f5495eefbc9826b1de1a008a2439351 [9/9] Smack: Brutalist io_uring support with debug > >> config: x86_64-randconfig-r013-20210526 (attached as .config) > >> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1) > >> reproduce (this is a W=1 build): > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> # install x86_64 cross compiling tool for clang build > >> # apt-get install binutils-x86-64-linux-gnu > >> # https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git/commit/?id=1f25193a3f5495eefbc9826b1de1a008a2439351 > >> git remote add pcmoore-selinux https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git > >> git fetch --no-tags pcmoore-selinux working-io_uring > >> git checkout 1f25193a3f5495eefbc9826b1de1a008a2439351 > >> # save the attached .config to linux build tree > >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > >> > >> If you fix the issue, kindly add following tag as appropriate > >> Reported-by: kernel test robot <lkp@xxxxxxxxx> > >> > >> All warnings (new ones prefixed by >>): > >> > >>>> security/smack/smack_lsm.c:4702:5: warning: no previous prototype for function 'smack_uring_override_creds' [-Wmissing-prototypes] > >> int smack_uring_override_creds(const struct cred *new) > >> ^ > >> security/smack/smack_lsm.c:4702:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > >> int smack_uring_override_creds(const struct cred *new) > >> ^ > >> static > >>>> security/smack/smack_lsm.c:4739:5: warning: no previous prototype for function 'smack_uring_sqpoll' [-Wmissing-prototypes] > >> int smack_uring_sqpoll(void) > >> ^ > >> security/smack/smack_lsm.c:4739:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > >> int smack_uring_sqpoll(void) > >> ^ > >> static > >> 2 warnings generated. > > > FYI, Casey I took the liberty of making the Smack functions static (I > > had made the same mistake with the SELinux code). > > Thank you. If there was any doubt, the Smack function declarations > were taken directly from the SELinux versions. I figured that was the case, and for whatever it is worth I would have done the exact same thing :) -- paul moore www.paul-moore.com
