On Mon, Feb 8, 2021 at 2:35 PM bauen1 <j2468h@xxxxxxxxxxxxxx> wrote: > > On 2/8/21 6:43 PM, James Carter wrote: > > On Sat, Feb 6, 2021 at 4:05 PM bauen1 <j2468h@xxxxxxxxxxxxxx> wrote: > >> > >> + <list name="function"> > >> + <item>blockinherit</item> > >> + <item>call</item> > >> + <item>in</item> > >> + <item>macro</item> > >> + </list> > >> + > > > > I am not sure it adds a lot to have these as separate colors. > > I would at least like to have `macro`, `call` and `blockinherit` as separate colors, as these behave very differently from "normal" keywords / statements and more like function calls from a programming language. > They are usually also quite important when looking over policy so I think it's warranted. > > I'm less sure about the arrangement of `in`, but due to its special interaction I've also included it. > I can live with it. > > Also, when call is used as a permission, it is highlighted. It would > > be nice if that could be fixed. > > I don't think this could be fixed easily, the same is also true if e.g. `allow` (a keyword) is used as permission, e.g. > > (allow t1 (file (call))) > (allow t1 (file (allow))) > > This is harder to fix as currently the syntax has no concept of what a "permission" is and I don't want to make things too complicated. > It's pretty minor, so don't worry about fixing it. Thanks, Jim > -- > bauen1 > https://dn42.bauen1.xyz/
