On Tue, Nov 24, 2020 at 3:44 PM Lokesh Gidra <lokeshgidra@xxxxxxxxxx> wrote: > On Mon, Nov 23, 2020 at 2:43 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > On Mon, Nov 23, 2020 at 2:21 PM Lokesh Gidra <lokeshgidra@xxxxxxxxxx> wrote: > > > On Sun, Nov 22, 2020 at 3:14 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > > > On Wed, Nov 18, 2020 at 5:39 PM Lokesh Gidra <lokeshgidra@xxxxxxxxxx> wrote: > > > > > I have created a cuttlefish build and have tested with the attached > > > > > userfaultfd program: > > > > > > > > Thanks, that's a good place to start, a few comments: > > > > > > > > - While we support Android as a distribution, it isn't a platform that > > > > we common use for development and testing. At the moment, Fedora is > > > > probably your best choice for that. > > > > > > > I tried setting up a debian/ubuntu system for testing using the > > > instructions on the selinux-testsuite page, but the system kept > > > freezing after 'setenforce 1'. I'll try with fedora now. > > > > I would expect you to have much better luck with Fedora. > > Yes. It worked! Excellent :) > > > > - Your test program should be written in vanilla C for the > > > > selinux-testsuite. Looking at the userfaultfdSimple.cc code that > > > > should be a trivial conversion. > > > > > > > > - I think you have a good start on a test for the selinux-testsuite, > > > > please take a look at the test suite and submit a patch against that > > > > repo. Ondrej (CC'd) currently maintains the test suite and he may > > > > have some additional thoughts. > > > > > > > > * https://github.com/SELinuxProject/selinux-testsuite > > > > > > Thanks a lot for the inputs. I'll start working on this. > > > > Great, let us know if you hit any problems. I think we would all like > > to see this upstream :) > > I have the patch ready. I couldn't find any instructions on the > testsuite site about patch submission. Can you please tell me how to > proceed. You can post it to the SELinux mailing list, much like you would do a SELinux kernel patch. I'll take a look and I'll make sure Ondrej looks at it too. Thanks! -- paul moore www.paul-moore.com
