On Fri, 13 Nov 2020, Paul Moore wrote:
> Static checking revealed that a previous fix to
> netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
> this patches fixes that.
>
> Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Paul Moore <paul@xxxxxxxxxxxxxx>
Reviewed-by: James Morris <jamorris@xxxxxxxxxxxxxxxxxxx>
> ---
> net/netlabel/netlabel_unlabeled.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
> index fc55c9116da0..ccb491642811 100644
> --- a/net/netlabel/netlabel_unlabeled.c
> +++ b/net/netlabel/netlabel_unlabeled.c
> @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,
> u32 skip_bkt = cb->args[0];
> u32 skip_chain = cb->args[1];
> u32 skip_addr4 = cb->args[2];
> - u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
> + u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
> struct netlbl_unlhsh_iface *iface;
> struct list_head *iter_list;
> struct netlbl_af4list *addr4;
>
--
James Morris
<jmorris@xxxxxxxxx>
