On Mon, Nov 2, 2020 at 1:05 PM Richard Haines <richard_c_haines@xxxxxxxxxxxxxx> wrote: > On Mon, 2020-11-02 at 09:35 +0100, Ondrej Mosnacek wrote: > > This series enables testing all filesystems currently supported by > > the > > testsuite (ext4, xfs, jfs, vfat) using the [fs_]filesystem subtests > > without the need to run the tests manually or move to a different > > filesystem. The filesystems not available on the tested kernel are > > automatically excluded. > > > > The series also updates dependencies with the packages containing the > > required mkfs.* programs, fixes the mkfs.* invocation to not get > > stuck > > when testing jfs, and fixes error output appearing during a > > successful > > vfat test. > > > > Note: The F32 CI will start failing after this and the kernel update > > patches are merged (the old kernel on the image doesn't have the XFS > > quota fix). It will be necessary to bump the stable Fedora testing to > > F33. > > > > v2 changes: > > - added a patch to fix the vfat tests output > > - fixed behavior when fs tests are executed directly > > - simplified the code changed/added by the last patch > > > > Ondrej Mosnacek (4): > > README,travis: add e2fsprogs, jfsutils, and dosfstools to deps > > tests/filesystem: pipe "yes" to mkfs.* to fix jfs test > > tests/[fs_]filesystem: fix unwanted error output when testing vfat > > tests/[fs_]filesystem: test all filesystems > > > Apart from the minor nit in patch 1, all fs types tested okay so: > > Acked-by: Richard Haines <richard_c_haines@xxxxxxxxxxxxxx> Thanks, all four patches are now applied: https://github.com/SELinuxProject/selinux-testsuite/commits/071ec9c5e5f0442aae0b14f455ea6e6b34ada1e0 > > > > > README.md | 6 ++++ > > tests/Makefile | 8 +++-- > > tests/filesystem/Filesystem.pm | 2 +- > > tests/filesystem/ext4 | 1 + > > tests/filesystem/jfs | 1 + > > tests/filesystem/test | 58 +++++++++++++++--------------- > > tests/filesystem/vfat | 1 + > > tests/filesystem/xfs | 1 + > > tests/fs_filesystem/ext4 | 1 + > > tests/fs_filesystem/jfs | 1 + > > tests/fs_filesystem/test | 64 ++++++++++++++++-------------- > > ---- > > tests/fs_filesystem/vfat | 1 + > > tests/fs_filesystem/xfs | 1 + > > travis-ci/run-testsuite.sh | 3 ++ > > 14 files changed, 83 insertions(+), 66 deletions(-) > > create mode 120000 tests/filesystem/ext4 > > create mode 120000 tests/filesystem/jfs > > create mode 120000 tests/filesystem/vfat > > create mode 120000 tests/filesystem/xfs > > create mode 120000 tests/fs_filesystem/ext4 > > create mode 120000 tests/fs_filesystem/jfs > > create mode 120000 tests/fs_filesystem/vfat > > create mode 120000 tests/fs_filesystem/xfs > > > -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc.
