On Mon, Nov 2, 2020 at 1:03 PM Richard Haines <richard_c_haines@xxxxxxxxxxxxxx> wrote: > > On Mon, 2020-11-02 at 09:35 +0100, Ondrej Mosnacek wrote: > > They are needed for ext4, jfs, and vfat tests, which will become > > executed by default in an upcoming patch. > > > > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx> > > --- > > README.md | 6 ++++++ > > travis-ci/run-testsuite.sh | 3 +++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/README.md b/README.md > > index 838a082..1149f30 100644 > > --- a/README.md > > +++ b/README.md > > @@ -58,6 +58,9 @@ similar dependencies): > > * keyutils-libs-devel _(tools used by the keys tests)_ > > * kernel-devel _(used by the kernel module tests)_ > > * quota, xfsprogs-devel and libuuid-devel _(used by the filesystem > > tests)_ > > +* e2fsprogs _(used by the ext4 filesystem tests)_ > > +* jfsutils _(used by the jfs filesystem tests)_ > > +* dosfstools _(used by the vfat filesystem tests)_ > > * nftables _(used by inet_socket and sctp tests if ver >= 9.3 for > > secmark testing )_ > > > > On a modern Fedora system you can install these dependencies with > > the > > @@ -81,6 +84,9 @@ following command (NOTE: On Fedora 32 and below you > > need to remove > > quota \ > > xfsprogs-devel \ > > libuuid-devel \ > > + e2fsprogs \ > > + jfsutils \ > > + dosfstools \ > > I guess these should also be under Debian as well. Yes, absolutely! I missed that section, because I saw only the line "apt-get install selinux-basics selinux-policy-default auditd" and thought that there is no such comprehensive list for Debian... Should have looked more carefully. Given that this is just documentation, I'll add them when applying so I don't need to repost everything. I'll make sure to double-check the package names, which might be different on Debian. Thank you for the review! > > > nftables \ > > kernel-devel-$(uname -r) \ > > kernel-modules-$(uname -r) > > diff --git a/travis-ci/run-testsuite.sh b/travis-ci/run-testsuite.sh > > index 051f9d8..bd9073c 100755 > > --- a/travis-ci/run-testsuite.sh > > +++ b/travis-ci/run-testsuite.sh > > @@ -38,6 +38,9 @@ dnf install -y \ > > quota \ > > xfsprogs-devel \ > > libuuid-devel \ > > + e2fsprogs \ > > + jfsutils \ > > + dosfstools \ > > kernel-devel-"$(uname -r)" \ > > kernel-modules-"$(uname -r)" > > > -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc.