On Fri, Oct 30, 2020 at 10:55 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote: > On Tue, Oct 13, 2020 at 4:55 PM Richard Haines > <richard_c_haines@xxxxxxxxxxxxxx> wrote: > > > > This patch allows BTRFS filesystems to be tested. > > > > The tests/filesystem all pass using './test -f btrfs' on Fedora 32. > > For me, also these tests are failing (41 of 58): > > Test Summary Report > ------------------- > filesystem/btrfs/test (Wstat: 10496 Tests: 58 Failed: 41) > Failed tests: 3-4, 10, 13-15, 17-25, 27-28, 30-37, 39-45 > 47-55 > Non-zero exit status: 41 Oh, never mind... The reason why these were failing was that btrfs-progs was not installed on the system. After installing that package, only the fs_filesystem tests fail for btrfs. Please add btrfs-progs as a dependency to README.md and travis-ci/run-testsuite.sh in future versions of the patch. > fs_filesystem/btrfs/test (Wstat: 10752 Tests: 57 Failed: 42) > Failed tests: 3, 9-10, 13-26, 28-36, 38-44, 46-54 > Non-zero exit status: 42 > > See full log here: > https://travis-ci.com/github/WOnder93/selinux-testsuite/jobs/422684295#L2711 > > (Don't be confused by the unusual test output - I'm experimenting with > running the tests for all filesystems in a single testsuite run.) > > And on related note, the existing vfat tests are also failing: > Test Summary Report > ------------------- > filesystem/vfat/test (Wstat: 7936 Tests: 43 Failed: 31) > Failed tests: 3-4, 6-7, 10-12, 14-19, 21-22, 24-36, 38-40 > Non-zero exit status: 31 > fs_filesystem/vfat/test (Wstat: 8192 Tests: 42 Failed: 32) > Failed tests: 3, 5-7, 10-20, 22-35, 37-39 > Non-zero exit status: 32 And this might be the same problem, but with dosfstools... I'll need to check. > > Full log here: https://travis-ci.com/github/WOnder93/selinux-testsuite/jobs/422652226#L2703 > > > The tests/fs_filesystem fail 42 of 57 using './test -f btrfs' on Fedora 32. > > > > As Fedora 33/Rawhide now defaults to using btrfs, running 'make test' will > > fail 42 of 57 fs_filesystem tests (tested on Rawhide). > > > > These fs_filesystem failures are caused by a bug when using the fsmount(2) > > type calls that was reported in [1]. > > I'll try to dig into this a little bit. It seems that FS maintainers > are not interested :( > > > > > Note btrfs requires a much larger image size (min 115 MiB), and therefore > > takes more than 2x longer to run tests than ext4. > > > > [1] https://lore.kernel.org/selinux/c02674c970fa292610402aa866c4068772d9ad4e.camel@xxxxxxxxxxxxxx/ > > > > Richard Haines (1): > > selinux-testsuite: Add BTRFS support for filesystem tests > > > > tests/filesystem/Filesystem.pm | 10 +++++++++- > > tests/filesystem/test | 6 ++++++ > > tests/fs_filesystem/test | 6 ++++++ > > 3 files changed, 21 insertions(+), 1 deletion(-) > > > > -- > > 2.26.2 > > > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel > Red Hat, Inc. -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc.