Re: [PATCH testsuite] tests/sctp: bump connect timeout to 4 seconds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 31, 2020 at 4:13 PM Stephen Smalley
<stephen.smalley.work@xxxxxxxxx> wrote:
>
> On Thu, Aug 27, 2020 at 4:11 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> >
> > The current value of 2 seconds causes transient failures too often in
> > certain slow/unstable environments (including the nested KVM Travis CI
> > setup). Our experience from downstream testing at Red Hat (across a
> > variety of HW and architectures) has shown that a value of 4 seconds
> > yields only very sporadic failures.
> >
> > Therefore, change the value to 4 to trade off some testing time for more
> > stability.
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
>
> As much as I dislike relying on timeouts and making the testsuite even
> slower, I don't have any better solution.
>
> Acked-by:  Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> (feel free to merge it yourself)

Thanks, merged.

-- 
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel
Red Hat, Inc.




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux