From: kernel test robot <lkp@xxxxxxxxx>
Use kmemdup rather than duplicating its implementation
Generated by: scripts/coccinelle/api/memdup.cocci
Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
CC: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
head: 37ea433c66070fcef09c6d118492c36299eb72ba
commit: c7c556f1e81bb9e09656ed6650d0c44c84b7c016 [4/6] selinux: refactor changing booleans
:::::: branch date: 4 hours ago
:::::: commit date: 2 days ago
conditional.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -686,12 +686,11 @@ static int cond_bools_copy(struct hashta
{
struct cond_bool_datum *datum;
- datum = kmalloc(sizeof(struct cond_bool_datum), GFP_KERNEL);
+ datum = kmemdup(orig->datum, sizeof(struct cond_bool_datum),
+ GFP_KERNEL);
if (!datum)
return -ENOMEM;
- memcpy(datum, orig->datum, sizeof(struct cond_bool_datum));
-
new->key = orig->key; /* No need to copy, never modified */
new->datum = datum;
return 0;
