Re: [PATCH testsuite v2 1/2] README: add perl-lib as a dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 11, 2020 at 5:05 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> On Tue, Aug 11, 2020 at 10:45 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> > The `lib` perl module has been split out of the `perl-interpreter`
> > package in Fedora 33 into `perl-lib`. It is needed for the filesystem
> > tests. Add it to the dependencies.
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
> > ---
> >  README.md | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/README.md b/README.md
> > index ff0a0dc..bfd5b17 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -45,6 +45,7 @@ similar dependencies):
> >  * perl-Test  _(test harness used by the testsuite)_
> >  * perl-Test-Harness _(test harness used by the testsuite)_
> >  * perl-Test-Simple _(for `Test::More`)_
> > +* perl-lib _(for `lib`; split out from `perl-interpreter` since Fedora 33)_
> >  * selinux-policy-devel _(to build the test policy)_
> >  * gcc _(to build the test programs)_
> >  * libselinux-devel _(to build some of the test programs)_
> > @@ -65,6 +66,7 @@ following command:
> >         # dnf install perl-Test \
> >                 perl-Test-Harness \
> >                 perl-Test-Simple \
> > +               perl-lib \
>
> Note that this package doesn't exist on the earlier versions, so the
> command will now work verbatim only on F33+... I'm not sure if we want
> to add --skip-broken (might silently skip necessary packages in case
> of dependency problems in the repos) or just leave it be.

I agree that '--skip-broken' is probably not the best choice for the
reasons you already mentioned.  I might suggest that if the package is
not present in all of the supported versions of Fedora we should add a
note to the README.md explaining that.  Once the older versions become
unsupported the note can be removed.

-- 
paul moore
www.paul-moore.com



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux