On Thu, Aug 6, 2020 at 12:37 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Thu, 6 Aug 2020 08:32:38 -0400 > Stephen Smalley <stephen.smalley.work@xxxxxxxxx> wrote: > > > > > > In the commit message or in a Documentation/trace/events-avc.rst ? > > > > I was just asking for it in the commit message / patch description. I > > don't know what is typical for Documentation/trace. > > No, the Documentation/trace is for generic tracing documentation. Not > for individual events. As I've said many times in the past, I've never rejected a patch because the patch description was too verbose, but I have rejected patches where the description hasn't provided enough useful information. I would really like to see the commit description show an example where you setup/load/etc. the event into the kernel, trigger and capture the event information, and then show how the event output can be parsed/processed into something meaningful by a user. I'm essentially looking for a "hello world" version of the SELinux tracepoint, does that make sense? -- paul moore www.paul-moore.com
