On Thu, Jul 09, 2020 at 09:32:37AM -0400, Stephen Smalley wrote:
> On Thu, Jul 9, 2020 at 5:46 AM Petr Lautrbach <plautrba@xxxxxxxxxx> wrote:
> >
> >
> > I'd like to release 3.1 today/tommorow to open the development of other
> > performance related improvemenets which which postponed. This is release notes
> > draft which is based on RELEASE-20200518.txt and RELEASE-20200619.txt:
> >
> > RELEASE 202007XX (3.1)
> >
> > User-visible changes:
> >
> > * selinux/flask.h and selinux/av_permissions.h were removed
>
> Also sepol/policydb/flask.h although hopefully there were no external
> users of it.
Added
> > * `security_compute_user()` was deprecated - usage of /sys/fs/selinux/user { security:compute_user } might be revisited
>
> Not sure what the last part "might be revisited" means; we have
> removed all uses of it internal to libselinux and deprecated the
> interface, with the intent of someday dropping it altogether and
> removing the kernel interface.
I've dropped " - usage of ... " part completely to make it simple
> One other user-visible change is commit
> 8677ce5e8f592950ae6f14cea1b68a20ddc1ac25 ("libsepol,checkpolicy:
> support omitting unused initial sid contexts") which allows policies
> to start omitting unused initial SID contexts going forward, as per
> its description and
> https://github.com/SELinuxProject/selinux-kernel/issues/12.
>
Added
On Thu, Jul 09, 2020 at 05:23:13PM +0200, Ondrej Mosnacek wrote:
> Hi,
>
> a couple nits below...
>
> On Thu, Jul 9, 2020 at 11:45 AM Petr Lautrbach <plautrba@xxxxxxxxxx> wrote:
> [...]
> >
> > * Support for new polcap genfs_seclabel_symlinks
>
> s/polcap/policy capability/ ?
Changed
> >
> > * New `setfiles -E` option - treat conflicting specifications as errors, such
> > as where two hardlinks for the same inode have different contexts.
> >
> > * `restorecond_user.service` - new systemd user service which runs `restorecond -u`
> >
> > * `setsebool -V` reports errors from commit phase
> >
> > * Improved man pages
> >
> > * `semanage` uses ipaddress Python module instead of IPy
> >
> > * matchpathcon related interfaces are deprecated
> >
> > * selinuxfs is mounted with noexec and nosuid
> >
> > * Improved README which was renamed to README.md and converted to markdown.
>
> This is more of a developer/packager/builder visible change rather
> than user visible IMHO. Maybe move it to a "Development-related
> changes" section?
>
> >
> > * `setup.py` builds can be customized using PYTHON_SETUP_ARGS, e.g. to for
> > Debian Python layout use: `make PYTHON_SETUP_ARGS=--install-layout=deb ...`
>
> Ditto. Maybe the "Packaging-relevant changes" would fit better for this one?
>
> >
> > * the dso wrappers for internal calls were removed and it is now strongly recommended to CFLAGS with
> > `-fno-semantic-interposition`
> >
> > * `security_compute_user()` was deprecated - usage of /sys/fs/selinux/user { security:compute_user } might be revisited
> >
> > * checkpolicy treats invalid characters as an error - it might break (but intentional) rare use cases
>
> I'd reword this to "might break rare use cases (intentionally)".
>
> >
> > * New `restorecon -x` option - prevent `restorecon` from crossing file system
> > boundaries.
>
> "New `restorecon -x` option, which prevents it from crossing file
> system boundaries"?
>
> >
> > * Handle `semanage module` in semanage bash completion
> >
> > * Added section about CFLAGS to README.md, see Packaging-relevant changes
>
> Also mainly devel/packager-related.
>
> >
> > * Improved man pages
>
> This one is already listed further above .
>
> >
> > * Add Travis CI job to run SELinux kernel testsuite on latest Fedora cloud image
>
> Another purely development-related change.
>
> >
> > * `sepolgen-ifgen` parses a gen_tunable statement as bool
> >
> > * `semanage` handles getprotobyname() failure case on Debian where /etc/protocols does not contain an entry for "ipv4"
> >
> > Packaging-relevant changes:
> [...]
>
I've applied all your suggestions. The updated version is bellow.
Thanks for the feedback!
RELEASE 202007XX (3.1)
======================
User-visible changes
--------------------
* selinux/flask.h, selinux/av_permissions.h and sepol/policydb/flask.h were removed
The flask.h and av_permissions.h header files were deprecated and
all selinux userspace references to them were removed in
commit 76913d8adb61b5 ("Deprecate use of flask.h and av_permissions.h.")
back in 2014 and included in the 20150202 / 2.4 release.
All userspace object managers should have been updated
to use the dynamic class/perm mapping support since that time.
Remove these headers finally to ensure that no users remain and
that no future uses are ever introduced.
Use string_to_security_class(3) and string_to_av_perm(3) to map the class and
permission names to their policy values, or selinux_set_mapping(3) to create a
mapping from class and permission index values used by the application to the
policy values.
* Removed restrictions in libsepol and checkpolicy that required all declared
initial SIDs to be assigned a context.
* Support for new policy capability genfs_seclabel_symlinks
* New `setfiles -E` option - treat conflicting specifications as errors, such
as where two hardlinks for the same inode have different contexts.
* `restorecond_user.service` - new systemd user service which runs `restorecond -u`
* `setsebool -V` reports errors from commit phase
* Improved man pages
* `semanage` uses ipaddress Python module instead of IPy
* matchpathcon related interfaces are deprecated
* selinuxfs is mounted with noexec and nosuid
* the dso wrappers for internal calls were removed and it is now strongly recommended to CFLAGS with
`-fno-semantic-interposition`
* `security_compute_user()` was deprecated
* checkpolicy treats invalid characters as an error - might break rare use cases (intentionally)
* New `restorecon -x` option which prevents it from crossing file system boundaries.
* Handle `semanage module` in semanage bash completion
* `sepolgen-ifgen` parses a gen_tunable statement as bool
* `semanage` handles getprotobyname() failure case on Debian where /etc/protocols does not contain an entry for "ipv4"
Packaging-relevant changes
--------------------------
* Setting CFLAGS during the make process will cause the omission of many defaults. While the project strives
to provide a reasonable set of default flags, custom CFLAGS could break the build, or have other undesired
changes on the build output. Thus, be very careful when setting CFLAGS. CFLAGS that are encouraged to be
set when overriding are:
- -fno-semantic-interposition for gcc or compilers that do not do this. clang does this by default. clang-10 and up
will support passing this flag, but ignore it. Previous clang versions fail.
* `setup.py` builds can be customized using PYTHON_SETUP_ARGS, e.g. to for
Debian Python layout use: `make PYTHON_SETUP_ARGS=--install-layout=deb ...`
Development-relevant changes
----------------------------
* Improved README which was renamed to README.md and converted to markdown.
* Added Travis CI job to run SELinux kernel testsuite on latest Fedora cloud image
Issues fixed
------------
* https://github.com/SELinuxProject/selinux/issues/248
* https://github.com/SELinuxProject/selinux/issues/239
* https://github.com/SELinuxProject/selinux/issues/237
* https://github.com/SELinuxProject/selinux/issues/225
* https://github.com/SELinuxProject/selinux/issues/217
* https://github.com/SELinuxProject/selinux/issues/208
* https://github.com/SELinuxProject/selinux/issues/204
* https://github.com/SELinuxProject/selinux/issues/187
* https://github.com/SELinuxProject/selinux/issues/179
* https://github.com/SELinuxProject/selinux/issues/164
* https://github.com/SELinuxProject/selinux/issues/70
* https://github.com/SELinuxProject/selinux/issues/28
Attachment:
signature.asc
Description: PGP signature
