Hello Stephen,
Quoting Stephen Smalley (2020-07-07 14:26:59)
> On Wed, Jul 1, 2020 at 11:13 AM Antoine Tenart
> <antoine.tenart@xxxxxxxxxxx> wrote:
> > diff --git a/policycoreutils/setfiles/setfiles.c b/policycoreutils/setfiles/setfiles.c
> > index ed67b5f12245..4844875cfc6b 100644
> > --- a/policycoreutils/setfiles/setfiles.c
> > +++ b/policycoreutils/setfiles/setfiles.c
> > @@ -48,10 +48,9 @@ static __attribute__((__noreturn__)) void usage(const char *const name)
> > name, name);
> > } else {
> > fprintf(stderr,
> > - "usage: %s [-diIDlmnpqvEFW] [-e excludedir] [-r alt_root_path] spec_file pathname...\n"
> > - "usage: %s [-diIDlmnpqvEFW] [-e excludedir] [-r alt_root_path] spec_file -f filename\n"
> > - "usage: %s -s [-diIDlmnpqvFW] spec_file\n"
> > - "usage: %s -c policyfile spec_file\n",
> > + "usage: %s [-diIDlmnpqvEFW] [-e excludedir] [-r alt_root_path] [-c policyfile] spec_file pathname...\n"
> > + "usage: %s [-diIDlmnpqvEFW] [-e excludedir] [-r alt_root_path] [-c policyfile] spec_file -f filename\n"
> > + "usage: %s -s [-diIDlmnpqvFW] spec_file\n",
> > name, name, name, name);
>
> You didn't update the number of name arguments to reflect the format
> string change above.
Sorry for that, I'll fix it for v2!
Thanks,
Antoine
> make[2]: Entering directory
> '/home/travis/build/stephensmalley/selinux/policycoreutils/setfiles'
> clang -O2 -Werror -Wall -Wextra -Wmissing-format-attribute
> -Wmissing-noreturn -Wpointer-arith -Wshadow -Wstrict-prototypes
> -Wundef -Wunused -Wwrite-strings -fno-common
> -I/home/travis/build/stephensmalley/selinux/installdir/usr/include
> -DUSE_AUDIT -c -o setfiles.o setfiles.c
> setfiles.c:54:22: error: data argument not used by format string
> [-Werror,-Wformat-extra-args]
> name, name, name, name);
> ^^
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
