On Wed, May 27, 2020 at 6:10 PM Jonathan Lebon <jlebon@xxxxxxxxxx> wrote:
>
> This patch does for `getxattr` what commit 3e3e24b42043 ("selinux: allow
> labeling before policy is loaded") did for `setxattr`; it allows
> querying the current SELinux label on disk before the policy is loaded.
>
> One of the motivations described in that commit message also drives this
> patch: for Fedora CoreOS (and eventually RHEL CoreOS), we want to be
> able to move the root filesystem for example, from xfs to ext4 on RAID,
> on first boot, at initrd time.[1]
>
> Because such an operation works at the filesystem level, we need to be
> able to read the SELinux labels first from the original root, and apply
> them to the files of the new root. The previous commit enabled the
> second part of this process; this commit enables the first part.
>
> [1] https://github.com/coreos/fedora-coreos-tracker/issues/94
>
> Signed-off-by: Jonathan Lebon <jlebon@xxxxxxxxxx>
You might want to fix the comment style below, but otherwise,
Acked-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> ---
> security/selinux/hooks.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 0b4e32161b7..a2caf6e2313 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3334,7 +3334,11 @@ static int selinux_inode_getsecurity(struct inode *inode, const char *name, void
> char *context = NULL;
> struct inode_security_struct *isec;
>
> - if (strcmp(name, XATTR_SELINUX_SUFFIX))
> + /* If we're not initialized yet, then we can't validate contexts, so
> + * just let vfs_getxattr fall back to using the on-disk xattr.
> + */
coding-style says that multi-line comment style is to use a separate
line for the opening /* unless in net/
> + if (!selinux_initialized(&selinux_state) ||
> + strcmp(name, XATTR_SELINUX_SUFFIX))
> return -EOPNOTSUPP;
>
> /*
> --
> 2.25.4
>
