On Fri, May 22, 2020 at 9:46 AM Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> wrote: > > On Linux with musl libc, libfts isn't shipped with libc. > Hence, we link with $(FTS_LIBS) in src. > > Some (most) musl-based distribution choose to ship libfts as > a standalone shared object because their libfts is licensed under either > very permissive license or that implementation of libfts requires > attribution in every usage. > > Always link with $(FTS_LIBS) in utils to prevent undefined reference > problem on those platforms. > > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> > --- > libselinux/utils/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile > index aa2d3e1b..1a7da223 100644 > --- a/libselinux/utils/Makefile > +++ b/libselinux/utils/Makefile > @@ -45,6 +45,8 @@ override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS) > override LDFLAGS += -L../src > override LDLIBS += -lselinux $(FTS_LDLIBS) > PCRE_LDLIBS ?= -lpcre > +FTS_LDLIBS ?= > +override LDLIBS += $(FTS_LDLIBS) Hello, A few lines above there already is "override LDLIBS += -lselinux $(FTS_LDLIBS)". Why do you need to add $(FTS_LDLIBS) to LDLIBS again? Thanks, Nicolas
