On Mon, May 4, 2020 at 3:03 PM Petr Lautrbach <plautrba@xxxxxxxxxx> wrote: > On Fri, May 01, 2020 at 03:46:04PM +0200, Christian Göttsche wrote: > > On Debian the `distutils` module is patched, so `get_python_lib()` returns by default `/usr/lib/python3/dist-packages` (no minor version). > > > > Could you wrap the commit message to 75 chars per line, please? > > > But `setuptools` affecting setup.py is not patched to create the library directory at `/usr/lib/python3/dist-packages` by default, rather than a command line argument `--install-layout deb` is added. > > > > Add PYTON_SETUP_ARGS as argument to affected setup.py calls and add a note in the global ReadMe. > > Fix the file name - ReadMe -> README.md > > > > > See https://www.debian.org/doc/packaging-manuals/python-policy/packaging_tools.html section B.1. > > > > Fixes: https://github.com/SELinuxProject/selinux/issues/187 > > Please provide Signed-off-by: > > Also there's a conflicting patch which changes README.md as well - > https://patchwork.kernel.org/patch/11522349/ which I'm going to merge. Could you > please rebase this patch based on changes from the mentioned patch? > > Other than the comments above, I like the patch. Thanks! Also, please fix the typo: s/PYTON/PYTHON/g (both in the commit message and code/README). I only spotted it now after reading Petr's reply :) -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.
