On Mon, Apr 27, 2020 at 3:10 PM Christian Göttsche
<cgzones@xxxxxxxxxxxxxx> wrote:
>
> Am So., 26. Apr. 2020 um 20:14 Uhr schrieb Nicolas Iooss
> <nicolas.iooss@xxxxxxx>:
> >
> > On Mon, Apr 20, 2020 at 1:47 PM Christian Göttsche
> > <cgzones@xxxxxxxxxxxxxx> wrote:
> > >
> > > Follow-up of: 9eb9c9327563014ad6a807814e7975424642d5b9 ("Get rid of security_context_t and fix const declarations.")
> > >
> > > Use a wrapper macro, because swig does not accept typedef attributes.
> > >
> > > Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> >
> > Acked-by: Nicolas Iooss <nicolas.iooss@xxxxxxx>
> >
> > If nobody raises an objection, I will merge the patch tomorrow.
>
> Maybe this should be delayed after the deprecation patch series from
> William Roberts to match the same style;
> e.g. this patch uses a helper macro.
>
> I'll prepare an updated patch.
I was just about to look at this and suggest the same thing. I didn't
put a macro like this in selinux.h for the simple
reason that I didn't want to make it something considered public API.
I avoided if SWIG, since its really
a gnuc extension that most compilers support, and its inline with the
other extensions that get buy the
SWIG build.
I would nack it for those two reasons.
I just sent V4 of the series, so hopefully that one sticks. If you
wan't you can update the style now and resubmit. As we can merge
it in parallel to my series (there is no hard dependency), so you
don't have to wait for my series to land.
