Re: [PATCH v2 1/1] fix building against musl and uClibc libc libraries.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 7, 2020 at 4:02 PM <aduskett@xxxxxxxxx> wrote:
>
> From: Adam Duskett <Aduskett@xxxxxxxxx>
>
> Currently, the src/Makefile provides the FTS_LDLIBS when building against musl
> or uClibc. However, this is missing from utils/Makefile, which causes linking
> to fail.
>
> Add the FTS_LDLIBS variable to the LDLIBS variable in utils/Makefile to fix
> compiling against uClibc and musl.
>
> Signed-off-by: Adam Duskett <Aduskett@xxxxxxxxx>
> ---
> Changes v1 -> v2:
>   - Updated the patch series to the latest master.
>
>  libselinux/utils/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile
> index 36150638..a5632b7c 100644
> --- a/libselinux/utils/Makefile
> +++ b/libselinux/utils/Makefile
> @@ -45,7 +45,7 @@ endif
>
>  override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS)
>  override LDFLAGS += -L../src
> -override LDLIBS += -lselinux
> +override LDLIBS += -lselinux $(FTS_LDLIBS)
>  PCRE_LDLIBS ?= -lpcre
>
>  ifeq ($(ANDROID_HOST),y)
> --
> 2.25.2
>

I appreciate your thoroughness, but you don't really need to resend a
patch rebased on top of master unless
their are merge conflicts.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux