Re: [PATCH 1/1] fix building against musl and uClibc libc libraries.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I did that just now!

On Tue, Apr 7, 2020 at 1:27 PM Roberts, William C
<william.c.roberts@xxxxxxxxx> wrote:
>
> > -----Original Message-----
> > From: selinux-owner@xxxxxxxxxxxxxxx [mailto:selinux-owner@xxxxxxxxxxxxxxx]
> > On Behalf Of aduskett@xxxxxxxxx
> > Sent: Tuesday, April 7, 2020 1:43 PM
> > To: selinux@xxxxxxxxxxxxxxx
> > Cc: Adam Duskett <Aduskett@xxxxxxxxx>
> > Subject: [PATCH 1/1] fix building against musl and uClibc libc libraries.
> >
> > From: Adam Duskett <Aduskett@xxxxxxxxx>
> >
> > Currently, the src/Makefile provides the FTS_LDLIBS when building against musl
> > or uClibc. However, this is missing from utils/Makefile, which causes linking to fail.
> >
> > Add the FTS_LDLIBS variable to the LDLIBS variable in utils/Makefile to fix
> > compiling against uClibc and musl.
> >
> > Signed-off-by: Adam Duskett <Aduskett@xxxxxxxxx>
> > ---
> >  libselinux/utils/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile index
> > 36150638..a5632b7c 100644
> > --- a/libselinux/utils/Makefile
> > +++ b/libselinux/utils/Makefile
> > @@ -45,7 +45,7 @@ endif
> >
> >  override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS)
> > $(PCRE_CFLAGS)  override LDFLAGS += -L../src -override LDLIBS += -lselinux
> > +override LDLIBS += -lselinux $(FTS_LDLIBS)
> >  PCRE_LDLIBS ?= -lpcre
> >
> >  ifeq ($(ANDROID_HOST),y)
> > --
> > 2.25.1
>
> If you want me to use the PR you have open, force push your branch to update the commit
> message. Else I'll have to create a new-pr and close your old one.
>
> Your open PR is here:
> https://github.com/SELinuxProject/selinux/pull/193
>
> Something like:
> git pull --rebase origin master
> git push aduskett HEAD:fix-musl-and-uclibc-builds
>
> would be ideal.
>
> Acked-by: William Roberts <william.c.roberts@xxxxxxxxx>



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux