On Fri, Mar 20, 2020 at 5:54 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote: > <snip> > > # semodule -i test_add_levels.cil > libsemanage.add_user: user system_u not in password file > > Should that first "sysadm_u" argument actually be "root"? And are > these two lines really necessary? The test passes without them for me > on a non-MLS system. > Interesting. I wouldn't have thought the contexts would be valid without adding them to system_u... It seems to work so I removed them. <snip> > > + > > git am still complains about extra empty line at EOF here. I can fix > that easily when merging, but if you're going to respin the patch > because of the selinuxuser warning, then it would be nice to fix this, > too :) > > [...] I fixed all these and pushed. Thanks for the reviews.