On Wed, 2020-03-11 at 14:02 -0400, Stephen Smalley wrote: > On Wed, Mar 11, 2020 at 1:52 PM Richard Haines > <richard_c_haines@xxxxxxxxxxxxxx> wrote: > > On Wed, 2020-03-11 at 10:55 -0400, Stephen Smalley wrote: > > > On Tue, Mar 10, 2020 at 12:25 PM Richard Haines > > > <richard_c_haines@xxxxxxxxxxxxxx> wrote: > > > > I've revamped the nfs.sh to handle tests that require specific > > > > mount > > > > options, these plus many more are now in tests/nfs_filesystem. > > > > This > > > > only > > > > gets run by nfs.sh. > > > > > > I don't really understand why you moved tests that could only be > > > run > > > from nfs.sh out of it into > > > tests/nfs_filesystem? > > > > I only moved them as it seemed more in keeping with the testsuite. > > Would you prefer them in the shell script ? I don't mind either > > way. > > Previously they weren't dependent on the test policy (weren't running > in any test domain > or using any test types) and were only testing NFS labeling behavior. > I think you switched > them over to running in test domains and on test files/directories. > If we stay with the former, > then keeping them in nfs.sh makes more sense. If we choose the > latter, then moving them as > you have done makes more sense. Not sure about the tradeoffs here. I'll leave as is for now and see how it goes. > > One thing to double check is that if you move them and there is a > failure, is that failure reported > properly and propagated up to the shell script in a way that causes > the entire test to fail. Might be > but I haven't confirmed it. It does now. I've fixed all the highlighted problems now. Will send new patch set tomorrow. Thanks for feedback.
