On Wed, Mar 4, 2020 at 4:42 PM Joshua Brindle <joshua.brindle@xxxxxxxxxxxxxxx> wrote: > > - Ondrej's uses the more compact (range c0 c1023) notation in the cil policy. > > Easily fixed, obviously I didn't know range c0 c1023 was valid in > sensitivitycategory statements. Pretty nice actually. > > > - Ondrej's checks that checkpolicy supports policy version 32 in > > addition to the kernel, necessary to build the policy. > > I suppose that should be added. > > I'm not currently set up to re-test this but could fix it up next week. Ok, if fixing yours, then other items I noticed: - Ondrej's test script is more readable because he separated the MLS fields. - No need for ; in test_glblub.cil. - Some extraneous whitespace in your patch; try fixing with git am --whitespace=fix or fix by hand.
