On Fri, Feb 28, 2020 at 8:04 PM Stephen Smalley <stephen.smalley.work@xxxxxxxxx> wrote: > > On Fri, Feb 28, 2020 at 1:43 PM William Roberts > <bill.c.roberts@xxxxxxxxx> wrote: > > > > On Fri, Feb 28, 2020 at 12:35 PM Stephen Smalley > > <stephen.smalley.work@xxxxxxxxx> wrote: > > > > > > On Fri, Feb 28, 2020 at 10:49 AM <bill.c.roberts@xxxxxxxxx> wrote: > > > > diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile > > > > index c76110fbc650..f74dbeb983dd 100644 > > > > --- a/libselinux/src/Makefile > > > > +++ b/libselinux/src/Makefile > > > > @@ -90,7 +90,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi > > > > -Werror -Wno-aggregate-return -Wno-redundant-decls \ > > > > $(EXTRA_CFLAGS) > > > > > > > > -LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro > > > > +LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro-Wl,--version-script=libselinux.map > > > > > > /usr/bin/ld: warning: -z relro-Wl ignored > > > I guess you meant relro,-Wl but you don't want that either. -Wl has > > > to precede all the flags and it is already pre-pended later in the > > > Makefile. > > > > Grumble, did I ever say I *hate* Makefiles! v4 coming, im going to > > hold them so I can coalesce any other feedback > > into v4. > > (restored cc; I accidentally only replied to you) While at it, I personally prefer if options -soname and --version-script come first (like in libsepol/src/Makefile). This way, it is "easier" for packagers to make a difference between options that are really required and the options that could be removed if the need arises (-z,defs,-z,relro). But this is nitpicking, so feel free to ignore my comment. Thanks, Nicolas
