On Tue, Feb 18, 2020 at 4:40 PM Stephen Smalley <sds@xxxxxxxxxxxxx> wrote: > On 2/18/20 10:22 AM, Ondrej Mosnacek wrote: > > On Thu, Feb 13, 2020 at 2:40 PM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote: > >> According to profiling of semodule -BN, ebitmap_cardinality() is called > >> quite often and contributes a lot to the total runtime. Cache its result > >> in the ebitmap struct to reduce this overhead. The cached value is > >> invalidated on most modifying operations, but ebitmap_cardinality() is > >> usually called once the ebitmap doesn't change any more. > >> > >> After this patch, the time to do 'semodule -BN' on Fedora Rawhide has > >> decreased from ~14.6s to ~12.4s (2.2s saved). > > > > I have no idea why, but I'm now getting completely different times > > (10.9s vs. 8.9s) with the same builds on the same setup... I can no > > longer reproduce the slower times anywhere (F31/locally/...) so I have > > to assume it was some kind of glitch. Since the numbers show a similar > > magnitude of speed-up (and they depend on a bunch of HW/SW factors > > anyway), I'm not going to do another respin. The applying person (most > > likely Stephen) is free to fix the numbers when applying if they wish > > to do so. > > Thanks, applied with fixed times (although I don't really think it > matters very much). Maybe you're also picking up the difference from > the "libsepol/cil: remove unnecessary hash tables" change. No, that was actually the reason for the first correction. -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.
