Duplicate hashtab code in libsepol vs. policycoreutils/newrole?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello everyone,

I noticed that there is a duplicate hashtab.[hc] code from libsepol in
policycoreutils/newrole. Can this be deduplicated somehow? I can think
of three options:
1. link to libsepol (a bit unsafe, since hashtab symbols are not
versioned, but other programs already use non-versioned symbols form
libsepol anyway...),
2. statically link with libsepol's hashtab.o (libsepol code would be
needed in ../../libsepol to build newrole)
3. turn the newrole files into symlinks that link to libsepol ones
(similar issue as above, the symlinks would have to be substituted for
actual files when creating release archive).

If we really can't get rid of the duplicity, what should be the policy
for updating the hashtab code? Should the same changes be done
simultaneously to both copies? Or should we change only libsepol and
treat the newrole copy as mostly frozen legacy code?

The thing is, I'd like to make some small changes in them, but I'm not
sure how to handle the duplicity.

Thanks!

-- 
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux