Re: [Non-DoD Source] [PATCH userspace v2 0/4] Fix build with -fno-common

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/23/20 7:57 AM, Ondrej Mosnacek wrote:
GCC 10 is going to enable -fno-common by default [1], so fix all build
errors uncovered by it and add it to global CFLAGS to avoid introducing
new bugs.

Changes in v2:
  - remove also struct te_assert definition, which is also useless
  - redo cil_mem_error_handler to match commit 4459d635b8f1 as suggested
    by Jim Carter

Travis build: [2]

[1] https://gcc.gnu.org/gcc-10/porting_to.html#common
[2] https://travis-ci.org/WOnder93/selinux/builds/640875119

Ondrej Mosnacek (4):
   libsepol: fix CIL_KEY_* build errors with -fno-common
   libsepol: remove leftovers of cil_mem_error_handler
   checkpolicy: remove unused te_assertions
   Makefile: always build with -fno-common

  Makefile                        |   3 +-
  checkpolicy/checkpolicy.h       |  14 --
  libsepol/cil/src/cil.c          | 162 ++++++++++++++++
  libsepol/cil/src/cil_internal.h | 322 ++++++++++++++++----------------
  libsepol/cil/src/cil_mem.h      |   1 -
  libsepol/cil/src/cil_strpool.c  |   8 +-
  6 files changed, 329 insertions(+), 181 deletions(-)


This whole series was applied.
Thanks,
Jim

--
James Carter <jwcart2@xxxxxxxxxxxxx>
National Security Agency



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux