On Thu, Jan 16, 2020 at 7:49 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > On 1/16/2020 3:59 PM, Paul Moore wrote: > > On Thu, Jan 16, 2020 at 6:09 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > >> On 1/16/2020 4:04 AM, Ondrej Mosnacek wrote: > >>> This series contains some simplifications that I discovered while > >>> working on another patch. I believe they also save some run time > >>> (although not in any perf-critical paths) and some memory overhead. > >>> > >>> The first patch is a cleanup in security_load_policy() > >> It's a real nuisance that the security server code uses the > >> prefix "security_". If you're making significant changes in > >> the security server it would be really nice to clean up the > >> namespace collision. > > For all the people lurking on the mailing list reading Casey's > > response, *please* do not do this (without discussion). That change > > has the potential to wreck a development cycle. > > Of course discussion is critical, and breaking a development cycle > would be a Bad Thing. I only suggested this because I'm seeing a bit > of clean-up I would consider to be in the same vein. I was not > advocating disruption. Carry on. FWIW, the cleanup you've seen lately has been mostly removing empty wrapper functions and changing how we allocate/manage things; what you are proposing is mostly a bulk rename which is quite different in my mind. -- paul moore www.paul-moore.com