On Thu, Dec 19, 2019 at 4:48 AM Ravi Kumar Siddojigari <rsiddoji@xxxxxxxxxxxxxx> wrote: > > Sorry , Re-adding the patch below as requested. > > Stephen , > Issue is fixed with this 2 changes , Issue as even reproduced on v4.14 and similar changes work there also . > > -- > From 77c618006397c7a65ead257f3cb4e4fe3da2d4b8 Mon Sep 17 00:00:00 2001 > From: Jaihind Yadav <jaihindyadav@xxxxxxxxxxxxxx> > Date: Tue, 17 Dec 2019 17:25:47 +0530 > Subject: [PATCH] selinux: ensure we cleanup the internal AVC counters on error > in avc_update() > > In AVC update we don't call avc_node_kill() when avc_xperms_populate() > fails, resulting in the avc->avc_cache.active_nodes counter having a > false value. In last patch this changes was missed , so correcting it. > > Change-Id: Ic0298162cc766c0f21be7ab232e259766654dad3 > Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@xxxxxxxxxxxxxx> > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Two things: * As Stephen already pointed out, please don't include "Change-Id" metadata in your commit, that means nothing to the upstream kernel. * If the patch is really from Jaihind Yadav then they should include their sign-off, and preferably you would include your sign-off as well since you are the one posting the patch. Please look at the "Developer's Certificate of Origin" section in Documentation/process/submitting-patches.rst. -- paul moore www.paul-moore.com
