On 11/22/19 5:40 AM, Ondrej Mosnacek wrote:
When trying this on RHEL-7, I realized there is a missing kernel version check here (module_load kernel support was introduced in v4.7 [1]): ifneq ($(shell ./kvercmp $$(uname -r) 4.7),-1) ... endif It is quite a corner case to have a policy that supports module_load and a kernel that does not, but there is at least one distro that hits it, so I think it's worth it to add the explicit check. Stephen/Paul, is it trivial enough to add when merging the patch or should Richard repost it? [1] https://github.com/torvalds/linux/commit/61d612ea731e57dc510472fb746b55cdc017f371
Alternatively, you could exclude it on RHEL7 by adding it to the filter-out line under ifeq ($(DISTRO),RHEL7). Regardless, it is entirely up to you as to whether you want to fix it up on merge yourself or request a re-spin.
