On Tue, Oct 15, 2019 at 10:34 PM Petr Lautrbach <plautrba@xxxxxxxxxx> wrote: > > Nicolas Iooss <nicolas.iooss@xxxxxxx> writes: > > > Many functions are already marked "extern" in libsemanage's public > > headers and this will help using the content of the headers in order to > > automatically generate some glue code for Python bindings. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> > > Do you plan to provide a test which would guard libselinux.h and > libsemanage.h so that all new functions are added with extern? Yes. This series was the "part 1" of the 3 parts described in a previous thread (https://lore.kernel.org/selinux/CAJfZ7=kYpc3Y1EHHycGeQSqCoptyNAyEcx4=ZDP=O8NEKJQnyg@xxxxxxxxxxxxxx/) and "part 3" will consist in providing such a test, for example by comparing the output of "gcc -aux-info" (which adds "extern" to all functions) against the new method which will be used to generate some glue code of Python bindings. I am currently travelling so I am not able to do as much testing as I would like. If Michael Shigorin does not send patches for the remaining parts, I will work on them once I get back home. > > Anyway, for both > > Acked-by: Petr Lautrbach <plautrba@xxxxxxxxxx> Thanks, merged. Nicolas
