On Mon, Oct 7, 2019 at 3:20 PM Michael Shigorin <mike@xxxxxxxxxxxx> wrote: > > Hello, > please find attached the patch to (hopefully) improve > self-surgery script that uses gcc-specific -aux-info now. > Should help clang, icc and the like (in my case there's > no proper gcc port for the target platform just yet). > > -- > ---- WBR, Michael Shigorin / http://altlinux.org > ------ http://opennet.ru / http://anna-news.info Hello, How did you test this patch? On my system (Arch Linux x86-64), I get the following differences in the generated list of functions, for libselinux: +select +pselect -selinuxfs_exists This is because /usr/include/sys/select.h contains "extern int select (int __nfds, fd_set *__restrict __readfds," and "extern int pselect (int __nfds, fd_set *__restrict __readfds,", and because libselinux/include/selinux/selinux.h contains "int selinuxfs_exists(void);" without "extern". Your patch therefore changes things in a way that seems unintended. I nevertheless agree that making the build system use clang when CC=clang is a good idea. As the regular expression you sent is quite fragile, a possible way of preventing issues such as the differences I found is to try using both methods (-aux-info and -E) in a "make test" target and fail with a fatal error when they do not produce the same output (this fatal error would be caught by a continuous-integration system, which would make the developers aware of something wrong). Moreover, please send your patch inline, if possible (for example with "git send-email"), and add a "Signed-off-by:" line as documented in https://github.com/SELinuxProject/selinux/blob/master/CONTRIBUTING.md#contributing-code. Thanks, Nicolas
